Double encoding of & in 'url' for pagination causes pagination links to be broken

[Son Nguyen]

Version: 1.6.3, master
Platform: all
Browser: all

Hardcoded '&' after sanitisation becomes '&'.
All url passed to build_pagination need to be fixed.

Regression caused by bug #1079498
Related to the bug #1089282

[Son Nguyen (ngson2000)]

master: https://reviews.mahara.org/1918
1.6: https://reviews.mahara.org/#/c/1919
1.5: https://reviews.mahara.org/#/c/1920

[Kristina Hoeppner (kris-hoeppner)]

This also affects mahara.org

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1918
Committed: http://gitorious.org/mahara/mahara/commit/5efa4b2479dc1611ac6ea59e3e965c80b40987b9
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 5efa4b2479dc1611ac6ea59e3e965c80b40987b9
Author: Son Nguyen <email address hidden>
Date: Fri Dec 14 16:12:29 2012 +1300

    Fix double encoding of &amp; in 'url' for a pagination (Bug #1090203)

    Make sure the string '&amp;' does NOT passed to 'url' of a pagination.

    All values of 'url' passed to build_pagination were well investigated
    and fixed.
    All strings of '&amp;' were also well investigated

    Change-Id: Id35837459e9dcfc42d2d6133720123e85758aac1
    Signed-off-by: Son Nguyen <email address hidden>

[Ruslan Kabalin (rkabalin)]

Added some post-refactoring to make things consistent and ensure that nothing is added to the link if params array is empty

https://reviews.mahara.org/#/c/1924/

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1919
Committed: http://gitorious.org/mahara/mahara/commit/95981c2bf4074eb457897bdc543bddeeb49a8734
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.6_STABLE

commit 95981c2bf4074eb457897bdc543bddeeb49a8734
Author: Son Nguyen <email address hidden>
Date: Fri Dec 14 16:12:29 2012 +1300

    Fix double encoding of &amp; in 'url' for a pagination (Bug #1090203)

    Make sure the string '&amp;' does NOT passed to 'url' of a pagination.

    All values of 'url' passed to build_pagination were well investigated
    and fixed.
    All strings of '&amp;' were also well investigated

    Change-Id: Id35837459e9dcfc42d2d6133720123e85758aac1
    Signed-off-by: Son Nguyen <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1920
Committed: http://gitorious.org/mahara/mahara/commit/bc1428de09663e9ac1e4103b43496edf44ac90e6
Submitter: Melissa Draper (<email address hidden>)
Branch: 1.5_STABLE

commit bc1428de09663e9ac1e4103b43496edf44ac90e6
Author: Son Nguyen <email address hidden>
Date: Fri Dec 14 16:12:29 2012 +1300

    Fix double encoding of &amp; in 'url' for a pagination (Bug #1090203)

    Make sure the string '&amp;' does NOT passed to 'url' of a pagination.

    All values of 'url' passed to build_pagination were well investigated
    and fixed.
    All strings of '&amp;' were also well investigated

    Change-Id: Id35837459e9dcfc42d2d6133720123e85758aac1
    Signed-off-by: Son Nguyen <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/1924
Committed: http://gitorious.org/mahara/mahara/commit/0f121eb41fc633b430f8e14fdcc93f741027d4a8
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 0f121eb41fc633b430f8e14fdcc93f741027d4a8
Author: Ruslan Kabalin <email address hidden>
Date: Wed Dec 19 11:27:56 2012 +0000

    Refactor pagination url params for consistency purposes (bug #1090203)

    Also ensure that nothing is added if params array is empty

    Change-Id: Iebf5711e0defe79c92907f56e7936a721c18e94d
    Signed-off-by: Ruslan Kabalin <email address hidden>