Mahara

  1. Bug #1006634
  2. Comment #40

Comment 40 for bug 1006634

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/1258
Committed: http://gitorious.org/mahara/mahara/commit/8432ef333681672608cdd83308ba5666432242b8
Submitter: Melissa Draper (<email address hidden>)
Branch: master

commit 8432ef333681672608cdd83308ba5666432242b8
Author: Richard Mansfield <email address hidden>
Date: Tue May 1 18:04:37 2012 +1200

    Use clean urls in View::get_url() function

    Bug #1006634, part 3

    The existing get_url method for views is modified to generate clean
    profile and group homepage urls.

    When the view is just a portfolio view, the view's urlid is appended
    to the user or group url. This requires calls to
    View::get_owner_object() and View::get_group_object(), which are
    potentially too slow to be calling on long lists of views, but this is
    addressed in subsequent commits.

    A flag is also added to force get_url to use old-style urls with ids.
    Sometimes an id is required by existing javascript which parses an
    href attribute.

    Change-Id: I8758cf2fc566f4c523c297d015c262007f365243
    Signed-off-by: Richard Mansfield <email address hidden>