Clean URLs for user profiles, group homepages, portfolio pages
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Wishlist
|
Richard Mansfield |
Bug Description
An option to enable alternative clean URLs for user profiles, group homepages, and portfolio pages owned by users and groups. URLs will be chosen by their owners, will uniquely identify a page, and will be used in internally generated links in preference to the old-style links using integer id parameters.
See https:/
This bug has three parts:
1. Add url fields for profiles, groups, and portfolio pages, initialised using usernames, group names, and page titles, and let users edit these fields.
2. Let profile, group homepage and portfolio page content be identified by the new field instead of by id.
3. Use these url fields to create the links generated internally by Mahara.
Mahara Bot (dev-mahara) wrote : A change has been merged | #1 |
Mahara Bot (dev-mahara) wrote : | #2 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 178e6399d6e7431
Author: Richard Mansfield <email address hidden>
Date: Mon Apr 23 13:42:45 2012 +1200
Add clean url configuration options to config-defaults (bug #1006634)
Change-Id: Ie2cc733185c0f5
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #3 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit c078f25f4c96a4c
Author: Richard Mansfield <email address hidden>
Date: Mon Apr 23 13:45:07 2012 +1200
New function for generation of clean urlid fields
Bug #1006634, part 1
Given a string possibly containing characters that are invalid in a
clean url, return a new string, of the allowed length, containing only
valid clean url characters. If converting utf8 to ascii,
transliterate using the iconv function.
Change-Id: I3dfc505e2be327
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #4 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 7e189ab64e750bc
Author: Richard Mansfield <email address hidden>
Date: Mon Apr 23 13:49:55 2012 +1200
Autogenerate clean urlids for new users, groups, and portfolio pages
Bug #1006634, part 1
Whenever a new user, group, or portfolio page is created and clean
urls are enabled, ensure the urlid field is set to something vaguely
sensible. Ensure new user and group urlids are unique, and ensure new
view urlids are unique for the owner.
Change-Id: I2033f5aa1f3265
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #5 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit bc80fa0ad1b7a82
Author: Richard Mansfield <email address hidden>
Date: Mon Apr 23 15:36:27 2012 +1200
Add admin page to generate clean URLs
Bug #1006634, part 1
Clean urls can be enabled at any time. Initialisation for existing
users should not be tied to a site upgrade, because it is slow, and
most sites won't ever enable it. Instead, add an admin page with a
button to regenerate all clean urls based on existing usernames, group
names, and page titles.
Change-Id: Id8bae56a6500b1
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #6 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 5c3cdcc6808e2bc
Author: Richard Mansfield <email address hidden>
Date: Mon Apr 23 14:09:37 2012 +1200
Allow users to edit clean urls
Bug #1006634, part 1
Allows users to edit the user, group, and portfolio page urlid fields.
Profile page urls are editable on the account settings page, group
homepage urls on the edit group page, and portfolio page urls under
Edit Title and Description in the view editor.
Change-Id: I2804d356fab544
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #7 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 15e062d78fbb2c7
Author: Richard Mansfield <email address hidden>
Date: Mon Apr 23 17:35:45 2012 +1200
Find profiles, group homepages, and portfolio pages by urlid
Bug #1006634, part 2
Reads new query parameters on user/view.php, group/view.php, and
view/view.php, which are expected to contain valid urlid values, and
finds the appropriate view based on these instead of an id.
Change-Id: I6bff25311afb3c
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #8 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 11f4a6315ca33b1
Author: Richard Mansfield <email address hidden>
Date: Mon Apr 23 18:44:02 2012 +1200
Use clean group urls on find/my groups
Bug #1006634, part 3
Adds a new function to generate a group homepage url from a group
object, and uses this function instead of a hardcoded url in the group
lists on Find Groups and My Groups.
Change-Id: I325998b762dde6
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #9 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 7ea7efd17730ed1
Author: Richard Mansfield <email address hidden>
Date: Tue Apr 24 13:43:26 2012 +1200
Use group_homepage_url for group links when url is available
Bug #1006634, part 3
Replaces a bunch of hardcoded group/view.php urls with calls to
group_
property is already part of the group object available at that point.
Change-Id: I7475d378d406a5
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #10 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit f2af094020ab7fd
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 17:16:21 2012 +1200
Use clean group urls on view access page
Bug #1006634, part 3
Adds the url id to the information returned by search_group, and
passes this into the javascript in the "Share with other users and
groups" fieldset on the Edit access page.
Change-Id: Ie5b88afba4a76b
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #11 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit f4f4589d6172666
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 17:14:43 2012 +1200
Use clean group url for redirect after editing group hompepage access
Bug #1006634, part 3
In fact, this url was previously unused, because the $redirecturl
variable was being clobbered immediately after the view type test.
Change-Id: If8695b5750599b
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #12 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 82b7f5ae4543840
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 17:14:05 2012 +1200
Use clean group url in 'you have submitted this view...' message
Bug #1006634, part 3
For the text under views that have been submitted to groups on
Portfolio -> Pages.
Change-Id: Id6a0d193e0379d
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #13 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 6a2b2e3544af108
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 17:13:05 2012 +1200
Use clean group urls on group topics page
Bug #1006634, part 3
For the linked group names listed in Groups -> Topics
Change-Id: I7cf0105ec08f80
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #14 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 9af5e76f1366850
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 15:25:53 2012 +1200
Use clean profile urls on the view access page
Bug #1006634, part 3
Adds the profile url to the information returned by search_user, and
passes this into the javascript in the "Share with other users and
groups" fieldset on the Edit access page.
Change-Id: I9dc34ce94c30d8
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #15 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 43559c30ced384d
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 14:54:22 2012 +1200
Use clean urls in tagged posts block
Bug #1006634, part 3
Because the urlid field is required here, this patch also modifies the
block to use the display_name function rather than firstname and
lastname.
Change-Id: Ie24a5bfa51595d
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #16 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit ca06d2ecd0c7cbc
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 14:34:13 2012 +1200
Use clean urls on share page
Bug #1006634, part 3
For user and group links under "Access list" on the share tab.
Change-Id: I48f0f78cf3741b
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #21 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 10401ccce81d551
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 14:23:47 2012 +1200
Use clean profile and group urls in the artefactchooser
Bug #1006634, part 3
This is used when configuring a textbox block, and the user has access
to 'note' artefacts with a different owner. For example, when adding
a group or institution note into a personal view.
Change-Id: I80259c769d7198
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #17 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit a8225b720e3dc6c
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 13:58:03 2012 +1200
Use clean profile urls in forums area
Bug #1006634, part 3
These changes will call profile_url on user ids rather than user
records or objects, but this will not result in any additional queries
on these pages: the users are (unfortunately) already being fetched
one by one to run display_name.
Change-Id: Ia744e06fcbf761
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #18 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 853e86478c80fb8
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 13:40:17 2012 +1200
Use get_user_
Bug #1006634, part 3
This is more efficient on many pages, because the user object has
already been fetched, or is about to be fetched, to run display_name
or profile_icon_url.
However, user object returned by get_user_
can_view_view to tell whether a user is suspended or not, so
suspendedctime is added to this object (it's less identifying than
suspendedcusr).
Change-Id: Ic9d1e5d437aedb
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #19 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 022f91cb5bc69f9
Author: Richard Mansfield <email address hidden>
Date: Mon May 7 17:28:34 2012 +1200
Use clean profile urls on the users tab of the site stats page
Bug #1006634, part 3
This is for the anecdotal snippets like 'Most is Bob with 55', etc.
Change-Id: If353facdab7a18
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #25 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 532a72e8c5a9353
Author: Richard Mansfield <email address hidden>
Date: Mon May 7 17:12:03 2012 +1200
Use clean urls on notes page
Bug #1006634, part 3
Passes the view records through get_extra_
Change-Id: Ic9b108f4c58140
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #31 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit f2b8d35914e573b
Author: Richard Mansfield <email address hidden>
Date: Mon May 7 17:18:41 2012 +1200
Replace miscellaneous hardcoded view urls
Bug #1006634, part 3
Change-Id: I643746b18d01fa
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #23 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 404ca468c6217f0
Author: Richard Mansfield <email address hidden>
Date: Mon May 7 13:14:37 2012 +1200
Use clean urls in watchlist block
Bug #1006634, part 3
Passes the view records through get_extra_
Change-Id: I71fbf2e56bee24
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #20 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 0ed69fcf6fe2786
Author: Richard Mansfield <email address hidden>
Date: Mon May 7 12:03:31 2012 +1200
When releasing a view, redirect to the clean group or view url
Bug #1006634, part 3
Use the global $submittedgroup in releaseview_
contains the group record.
Change-Id: I3ad549cd8f0581
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #33 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit fe8eab18f8214bb
Author: Richard Mansfield <email address hidden>
Date: Mon May 7 11:51:27 2012 +1200
Use clean urls on the view submission page
Bug #1006634, part 3
Modifies the page to use a View object rather than a db record, so
that get_url can be used.
Change-Id: Idd92be967469cb
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #22 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit f40405862e64e4c
Author: Richard Mansfield <email address hidden>
Date: Mon May 7 11:42:53 2012 +1200
Use clean urls in admin stats area
Bug #1006634, part 3
Simplifies the view query and passes the results through
get_
Change-Id: I8c39548b00b026
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #36 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit c433512bc536aca
Author: Richard Mansfield <email address hidden>
Date: Fri May 4 16:43:50 2012 +1200
Use clean urls for views listed on my friends page
Bug #1006634, part 3
In order to get the url information for the list of views returned by
get_views(), that function is modified to gather the views in a single
flat list rather than in a structure indexed by user id. Just before
the view list is returned, the url information is fetched and the user
array is built.
Change-Id: I12dad07c90f8c5
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #24 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 1402a7c8a038594
Author: Richard Mansfield <email address hidden>
Date: Fri May 4 14:08:00 2012 +1200
Collect url information and display clean urls in collections
Bug #1006634, part 3
Updates the Collection::views() method to get a url along with each
view, and uses these in the templates related to collections.
Also gets the maximum and minimum displayorder fields by iterating
over returned records instead of performing additional queries.
Change-Id: Ia115f6057854f5
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #41 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 93d4824ae0f2c65
Author: Richard Mansfield <email address hidden>
Date: Thu Jun 7 14:26:46 2012 +1200
When changing urlid on the settings page, force a page reload
Bug #1006634, part 1
When a user changes their own url on settings, force a full page
reload so that the profile link in the sideblock works.
Also cleans up existing code to force a reload after a change of theme
or language preference.
Change-Id: Ic9c216d3d295b1
Mahara Bot (dev-mahara) wrote : | #27 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 6c6c24e7c999082
Author: Richard Mansfield <email address hidden>
Date: Thu May 3 18:37:11 2012 +1200
Use clean urls in profile sideblock
Bug #1006634, part 3
Only affects views that the owner has tagged 'profile'.
Change-Id: Id4a6b641ab46e6
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #26 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 6fe530c01c2d84a
Author: Richard Mansfield <email address hidden>
Date: Fri May 18 15:49:23 2012 +1200
Add an option to stop users from editing their profile urls
Bug #1006634, part 1
Some sites may wish to enforce a policy to leave profile urls as close
as possible to usernames.
Change-Id: I6931a34baaca91
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #32 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit ef835efea163268
Author: Richard Mansfield <email address hidden>
Date: Thu May 3 18:24:32 2012 +1200
Replace hardcoded urls on choose template page
Bug #1006634, part 3
These need to continue to use ids rather than clean urls, because
javascript on the page parses the href attribute for user and group
ids. It's still better to use the appropriate url functions anyway,
to reduce the number of hardcoded urls. Because clicks on these links
are intercepted by javascript to display a preview window, users will
not end up at these unclean urls unless they have disabled javascript.
Change-Id: I6d0378c6c65d06
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #34 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit bbb85f00fec6613
Author: Richard Mansfield <email address hidden>
Date: Thu May 3 17:56:04 2012 +1200
Use clean urls on view/artefact.php
Bug #1006634, part 3
The template can be simplified a bit by using View::display_
instead of generating titles and links for the view and its owner.
The owner_link function is called by display_title, and is updated
here to return clean urls.
Change-Id: Ia4653b2050be1f
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #30 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 9ef2afd8439547d
Author: Richard Mansfield <email address hidden>
Date: Thu May 3 16:28:57 2012 +1200
Use clean urls elsewhere in lib/view.php
Bug #1006634, part 3
- Releasing submitted views
- Display of view titles
- Redirects after submitting the objection form, and marking views as unobjectionable
Change-Id: I878eca87cbe8e2
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #38 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit a1ddaf0561a1c85
Author: Richard Mansfield <email address hidden>
Date: Thu May 3 15:59:04 2012 +1200
Use clean urls in view access notifications
Bug #1006634, part 3
Now uses View methods rather than a custom query.
Change-Id: I227652f197b488
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #28 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 6d83533b0abb1f6
Author: Richard Mansfield <email address hidden>
Date: Wed May 2 17:50:41 2012 +1200
Use clean urls in watchlist notifications
Bug #1006634, part 3
Use View methods instead of a custom query.
Change-Id: I2fb2eaa0d1cdbe
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #45 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 2abd5870506716e
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 17:24:09 2012 +1200
Delete urlids when deleting users and groups
Bug #1006634, part 1
Ensures that group and user urlids are freed up when users and groups
are deleted. Not required for views, because view rows are deleted
completely rather than just marked deleted.
Change-Id: Ibcf3549ac5ff18
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #29 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 4b0d6f7d823c3b0
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 17:17:12 2012 +1200
Use clean group url for notification after adding a user to a group
Bug #1006634, part 3
When adding a user to a group directly from a user profile.
Change-Id: If97f429b4cd110
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #35 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 16943862aac76c4
Author: Richard Mansfield <email address hidden>
Date: Tue May 8 17:16:41 2012 +1200
Use clean group urls in redirect after editing group homepage content
Bug #1006634, part 3
This is the destination for the "Done" button at the bottom of the
block editing page.
Change-Id: I0ecb734af63708
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #47 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 0fd04e12febd927
Author: Richard Mansfield <email address hidden>
Date: Wed May 2 16:52:21 2012 +1200
Use clean view urls on tags page
Bug #1006634, part 3
Views and artefacts are pulled from the db together in a UNION query.
We can't simply pass the whole list of records through to a View
method - it's easier to generate the urls one by one in
build_
Change-Id: I59b1ab91e14161
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #46 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit f51a7b57d713022
Author: Richard Mansfield <email address hidden>
Date: Wed May 2 16:46:17 2012 +1200
Use View::get_url() to generate view urls in view listings
Bug #1006634, part 3
Changes to get_extra_view_info allow the following pages to be updated
with clean view urls, without any performance penalty:
- Latest pages block
- get_views_for_user mnet function
- Group views block
- My views block
- Sitemaps
- Shared pages
Change-Id: I25be10092a7865
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #37 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 20aff7a81f371f5
Author: Richard Mansfield <email address hidden>
Date: Tue May 1 18:14:38 2012 +1200
Display clean urls on Portfolio->Pages aka My Views
Bug #1006634, part 3
Simplifies get_myviews_data() to make use of get_extra_
the results from that function now contain everything we need for
display on the page.
Change-Id: I16c826e93171ec
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #39 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 33404332d1fe438
Author: Richard Mansfield <email address hidden>
Date: Tue May 1 18:10:54 2012 +1200
Generate view urls in get_extra_view_info
Bug #1006634, part 3
This function is used when a set of view records needs to be augmented
with tags and data about the view owner (user, group, or institution).
It is useful on many pages to add the url of each view into the set of
results, because the url can no longer be determined from the view id
alone.
To use the get_url() method, a temporary View object is created, and
this is prepopulated with the appropriate owner or group (which we
have already pulled from the db), so that later calls to
get_
more queries.
Change-Id: I26528ff573d057
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #40 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 8432ef333681672
Author: Richard Mansfield <email address hidden>
Date: Tue May 1 18:04:37 2012 +1200
Use clean urls in View::get_url() function
Bug #1006634, part 3
The existing get_url method for views is modified to generate clean
profile and group homepage urls.
When the view is just a portfolio view, the view's urlid is appended
to the user or group url. This requires calls to
View:
potentially too slow to be calling on long lists of views, but this is
addressed in subsequent commits.
A flag is also added to force get_url to use old-style urls with ids.
Sometimes an id is required by existing javascript which parses an
href attribute.
Change-Id: I8758cf2fc566f4
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #42 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 623062100c045c2
Author: Richard Mansfield <email address hidden>
Date: Thu Apr 26 17:57:52 2012 +1200
Use clean urls for view owners after running view_search
Bug #1006634, part 3
The view_search() function retrieves data about the user or group who
owns each view in the result set, and this owner data is displayed in
the Group pages and Latest pages blocks, and Shared pages. When the
urlid column is also pulled from the db, user and group urls can be
generated using the new functions.
Change-Id: I4a018d8deba4a3
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #44 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 0d28fabc9264f20
Author: Richard Mansfield <email address hidden>
Date: Tue Apr 24 18:51:54 2012 +1200
Use profile_url when data is easy or inexpensive to fetch
Bug #1006634, part 3
In many places user urlids are not currently available when the
profile url is generated, but it is trivial to get it, and then change
the user/view.php url to a profile_url call:
- Admin page access report
- Profile links in feedback lists
- My friends block
- Wall posts
- Group members block
- Group members tab
- Recent forum posts block
- Group admin lists on forums page
- Group admin lists on my groups, find groups
- Group admin lists in group info block
- Profile sideblock
- My friends & find friends pages
- Institution landing page
- Online users page
Change-Id: I33e12289698203
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #43 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit 021d755b2da7405
Author: Richard Mansfield <email address hidden>
Date: Tue Apr 24 17:08:59 2012 +1200
Use clean profile urls on sendmessage, denyrequest pages
Bug #1006634, part 3
In these cases the user's url field is already fetched on the page,
but the database query must be moved to make use of it.
Change-Id: I325866c89577e5
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #48 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit ffb144ad10d0510
Author: Richard Mansfield <email address hidden>
Date: Tue Apr 24 14:37:29 2012 +1200
Use group_homepage_url when data is easy/inexpensive to fetch
Bug #1006634, part 3
Replaces existing group/view.php urls with calls to
group_
required to fetch the urlid property, and where it is clear it will
have little impact on performance:
- My groups block
- Cancel button on group delete
- Redirects after joining a group or inviting a user
- Group tab of the admin stats area
- My groups section of the profile sideblock
- Redirect after submitting a view
Change-Id: I0ab970bdc4aaef
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #49 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit e262b5bb664b24f
Author: Richard Mansfield <email address hidden>
Date: Tue Apr 24 17:03:01 2012 +1200
Use clean profile urls when data is already available
Bug #1006634, part 3
Adds a new profile_url function which respects the cleanurls
configuration, and makes use of this function in many places where the
user's url field is already available:
- Admin user account settings page
- Redirects after inviting/adding users to groups
- Redirects & notifications after accepting/denying friend requests or unfriending
- The name plate in the top right header & small view header
- Online users sideblock
- Display of threaded personal messages
Change-Id: Ia43ae0867af12f
Signed-off-by: Richard Mansfield <email address hidden>
Changed in mahara: | |
status: | In Progress → Fix Committed |
tags: | added: newfeature1.6 |
Kristina Hoeppner (kris-hoeppner) wrote : | #50 |
A clean URL is not created for some group pages. Richard and I saw the problem and he'll investigate.
on my install: pages (existing and new) in existing groups didn't get clean URL whereas pages in new groups have the option.
Changed in mahara: | |
status: | Fix Committed → In Progress |
Mahara Bot (dev-mahara) wrote : | #51 |
Reviewed: https:/
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit b8ecc4e27bf03b5
Author: Richard Mansfield <email address hidden>
Date: Wed Jun 13 10:57:19 2012 +1200
Remove use of bitwise assignments on boolean values
This patch removes some inapproprate uses of the |= and &= operators
on boolean values. On view/edit.php, &= was also used on the integer
return value from strlen as if it were a boolean, resulting in the
clean url field being uneditable in some instances where it should
have been editable (see bug #1006634).
Change-Id: I96a72c407309ed
Signed-off-by: Richard Mansfield <email address hidden>
Changed in mahara: | |
status: | In Progress → Fix Committed |
Mahara Bot (dev-mahara) wrote : | #52 |
Reviewed: https:/
Committed: http://
Submitter: Hugh Davenport (<email address hidden>)
Branch: master
commit 4497a47c7eb0987
Author: Richard Mansfield <email address hidden>
Date: Wed May 30 14:23:38 2012 +1200
Avoid cross-domain ajax requests from user subdomains (bug #1006634)
When cleanurlusersub
somewhere other than the wwwroot. To avoid cross-domain requests,
this patch will set a javascript variable whenever a page is on a
subdomain. The ajax wrapper function sendjsonrequest rewrites its url
using the variable if necessary.
Change-Id: If8a625268895fe
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #55 |
Reviewed: https:/
Committed: http://
Submitter: Hugh Davenport (<email address hidden>)
Branch: master
commit 79865c29556f58b
Author: Richard Mansfield <email address hidden>
Date: Mon Jun 18 17:02:24 2012 +1200
Use subdomain URLs on Settings and Edit view pages (bug #1006634)
When user subdomains are enabled, display the Profile url field on the
Settings page where it belongs: between the scheme part of the url and
the rest of the wwwroot.
On Edit Title & Description for profile pages, ensure the correct form
of the clean url is used by calling the appropriate function instead
of building the url.
Change-Id: Id4924165e7bf80
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #54 |
Reviewed: https:/
Committed: http://
Submitter: Hugh Davenport (<email address hidden>)
Branch: master
commit 8a09de28a24e0d9
Author: Richard Mansfield <email address hidden>
Date: Fri May 25 13:26:12 2012 +1200
Allow login redirect to subdomains (bug #1006634)
When a page at a user subdomain such as http://
is requested by a logged out user, ensure that the user is redirected
to a login page that works, rather than to http://
Because the existing get_full_
unused, this function is modified to call get_requested_
and then used in the AccessDeniedExc
redirect.
Change-Id: I182adeb1a83363
Signed-off-by: Richard Mansfield <email address hidden>
Mahara Bot (dev-mahara) wrote : | #56 |
Reviewed: https:/
Committed: http://
Submitter: Hugh Davenport (<email address hidden>)
Branch: master
commit 555b7606cad1349
Author: Richard Mansfield <email address hidden>
Date: Fri May 25 11:19:20 2012 +1200
Always use wwwroot to generate the cookie domain (bug #1006634)
When user subdomain urls are enabled, parts of the site are at
subdomains under wwwroot, and we need to ensure that cookies are set
with the main site domain to ensure users stay logged in when they go
to profile pages.
Change-Id: I8c8ac4e01078ff
Mahara Bot (dev-mahara) wrote : | #53 |
Reviewed: https:/
Committed: http://
Submitter: Richard Mansfield (<email address hidden>)
Branch: master
commit aab46e2b318d941
Author: Richard Mansfield <email address hidden>
Date: Fri May 25 13:29:49 2012 +1200
Add clean URL "User subdomain" option (bug #1006634)
This generates profile urls as subdomains of the site wwwroot. For
example, http://
URL http://
This option will not work without the appropriate rewrite rules,
documented at
https:/
Change-Id: I9e1cb479abf3b9
Hugh Davenport (hugh-davenport) wrote : | #57 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://
iJwEAQECAAYFAlC
lM8LXAwZWa6zFv6
pCQXI9E7huPw802
oWvTpl7Xuac48e6
=ouU+
-----END PGP SIGNATURE-----
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Reviewed: https:/ /reviews. mahara. org/1240 gitorious. org/mahara/ mahara/ commit/ f3b11d3cbf75841 2cb694841b8b164 3942c9db2d
Committed: http://
Submitter: Melissa Draper (<email address hidden>)
Branch: master
commit f3b11d3cbf75841 2cb694841b8b164 3942c9db2d
Author: Richard Mansfield <email address hidden>
Date: Mon Apr 23 10:47:26 2012 +1200
Add urlid fields to usr, group, and view tables
Bug #1006634, part 1
These columns will hold the portions of a full page url which relate
to users, groups, and views respectively.
Change-Id: I50e19f822ef2b8 e2f0116db81f27c b4d3bb1bd53
Signed-off-by: Richard Mansfield <email address hidden>