Comment 2 for bug 1504059

I'm currently seeing swarm clusters fail to correctly report their completion status to heat. I traced this through to the swarm heat templates in magnum using incorrect names for the waitcondition signals.

For example, see https://github.com/openstack/magnum/blob/4ad01cb867734e1cfbd2d681f8aa3c9d3ead0b2a/magnum/drivers/common/templates/swarm/fragments/write-swarm-master-service.sh#L54. The status, reason, data and id fields are capitalised to Status, Reason, Data and Id. Compare this with the k8s wait condition notifier: https://github.com/openstack/magnum/blob/4ad01cb867734e1cfbd2d681f8aa3c9d3ead0b2a/magnum/drivers/common/templates/kubernetes/fragments/wc-notify-master.sh#L14 and various examples of using wait conditions which can be found.

This explains why swarm clusters do not correctly report failure.