container_execute does not allow for interactive use

Bug #1459875 reported by Adrian Otto
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum
Invalid
Wishlist
Chuenlye

Bug Description

 In magnum/conductor/handlers/docker_conductor.py we define container_execute(), but we do not allow for the options to be set to allow a pseudo tty to be allocated to cause interactive operation with the command on the terminal.

Reference: http://docker-py.readthedocs.org/en/1.2.2/api/#exec_create

We pass the last argument as False, which disables the pseudo tty.

Correct this by allowing a -it command to "magnum container-exec" (consistent with docker's flags to request an interactive terminal) that causes that False value to be True.

Note that the CLI command may currently be "magnum container-execute", but changing that to "magnum container-exec" will be addressed in a separate bug.

Revision history for this message
Adrian Otto (aotto) wrote :
N Dillon (sicarie)
Changed in magnum:
assignee: nobody → N Dillon (sicarie)
Chuenlye (chuenlye-leo)
Changed in magnum:
assignee: N Dillon (sicarie) → Chuenlye (chuenlye-leo)
Revision history for this message
Chuenlye (chuenlye-leo) wrote :

I picked up this bug to fix for OpenStack Upstream Training in Tokyo.
First attempt at contributing code. Please help in anyway you see fit.

Adrian Otto (aotto)
Changed in magnum:
milestone: none → mitaka-1
Changed in magnum:
status: Triaged → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.