Comment 25 for bug 1323975

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Re: [Bug 1323975] Re: do not use default=None for config options

That does make sense. We can't change the API to require it without
breaking a lot of code, I'm sure, but you don't have to accept this
patch. I have no idea what is motivating this series of changes.

Doug

On Tue, Jun 17, 2014 at 7:08 AM, Duncan Thomas <email address hidden> wrote:
> No sure where (maybe on the review), but John Griffith made a comment I
> agree with, that maybe we actually prefer to be explicit about our
> defaults (Tao of Python and all that), rather than requiring implicit
> knowledge of the cfg module. Always requiring a default, even if it is
> None, might make for more readable code.
>
> Thoughts?
>
> --
> You received this bug notification because you are subscribed to
> Ceilometer.
> Matching subscriptions: All oslo, ceilometer-all
> https://bugs.launchpad.net/bugs/1323975
>
> Title:
> do not use default=None for config options
>
> Status in Project Barbican:
> Fix Committed
> Status in OpenStack Telemetry (Ceilometer):
> Fix Committed
> Status in Cinder:
> In Progress
> Status in OpenStack Image Registry and Delivery Service (Glance):
> Fix Released
> Status in Orchestration API (Heat):
> Fix Released
> Status in OpenStack Bare Metal Provisioning Service (Ironic):
> Fix Committed
> Status in OpenStack Identity (Keystone):
> Triaged
> Status in MagnetoDB - key-value storage service for OpenStack:
> New
> Status in OpenStack Message Queuing Service (Marconi):
> Fix Committed
> Status in OpenStack Neutron (virtual network service):
> Fix Released
> Status in OpenStack Compute (Nova):
> Incomplete
> Status in Oslo - a Library of Common OpenStack Code:
> Fix Released
> Status in Messaging API for OpenStack:
> Fix Released
> Status in OpenStack Data Processing (Sahara, ex. Savanna):
> Fix Released
> Status in Openstack Database (Trove):
> In Progress
>
> Bug description:
> In the cfg module default=None is set as the default value. It's not
> necessary to set it again when defining config options.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/barbican/+bug/1323975/+subscriptions