Navigation needs to be recovered when opening/reloading ngdetail page

Bug #1746706 reported by Akihiro Motoki on 2018-02-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Magnum UI
High
Shu Muto
OpenStack Dashboard (Horizon)
High
Shu Muto
Zun UI
High
Shu Muto
senlin-dashboard
Undecided
Shu Muto

Bug Description

Fix for bug 1681627 allows us to reload or directly open Angular-based detail page (ngdetail), but the navigation menu is not recovered correctly and the menu is focused on the first panel (Project -> API access in most cases).
This bug is used to track this problem.

There are several thing to be considered.
* How to know which panel a ngdetail page belongs to.
* How to know which dashboard a ngdetail page belongs to.

Perhaps most tricky thing is that at now there is a cases where a single ngdetail page is linked from both the project and admin dashboard, but there is no good way to known the dashboard information from URL. In case of reloading it might be recovered from browser history, but it does not work for opening a ngdetail page via a direct URL. We might need to revisit URL of ngdetail page to include a dashboard information as we do for Django panels and Angular Index page.

Changed in horizon:
assignee: nobody → Shu Muto (shu-mutou)
status: Confirmed → In Progress
Shu Muto (shu-mutou) wrote :

I proposed using query string to know which panel shows the ngdetails view.

Shu Muto (shu-mutou) wrote :

This does not be fixed perfectly by https://review.openstack.org/#/c/491346/ at situation like following case:

Originally navigation does not have specified menu. Since the non-admin user does not have menu for "Admin" dashboard, navigation will not be reproduced if "?nav=/admin/images/" specified at the end of URL like http://host.domain/ngdetails/OS::Glance::Image/ce46ef50-850a-46ed-8707-bd5b21e4f9b7?nav=%2Fadmin%2Fimages%2F

When we fix https://bugs.launchpad.net/horizon/+bug/1746709 , and it provides route for 404 page, it may good to route to 404 page if proper panel is not found.

Shu Muto (shu-mutou) wrote :

Previous issue (#2) was filed as new bug: https://bugs.launchpad.net/horizon/+bug/1761036

Reviewed: https://review.openstack.org/491346
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=8275d67949915e9b600559787cdb05bb23fdf337
Submitter: Zuul
Branch: master

commit 8275d67949915e9b600559787cdb05bb23fdf337
Author: Shu Muto <email address hidden>
Date: Thu May 25 18:39:15 2017 +0900

    Reproduce navigations on refreshing ngdetails view

    To setup proper navigation to side bar and breadcrumb,
    this patch adds new 'defaultIndexUrl' parameter and
    its getter/setter into resource-type-service.

    The 'defaultIndexUrl' parameter makes details view
    enable to set navigations properly in Angular-side.

    Each panel module should set URL for default index view
    using 'defaultIndexUrl' parameter. So, this patch adds
    the `defaultIndexUrl` parameter into existing panel
    modules that have Angularized details view.

    Also, if query string has 'nav' parameter, the
    navigation setting will be overwitten with it.
    This URL overwriting may be used by panels that has
    multiple index panels, like images panel.

    Change-Id: I2edd44e55eb10114e5282cec1762e9635881f733
    Closes-Bug: #1746706

Changed in horizon:
status: In Progress → Fix Released
Shu Muto (shu-mutou) on 2018-04-09
Changed in zun-ui:
assignee: nobody → Shu Muto (shu-mutou)
importance: Undecided → High
status: New → In Progress
milestone: none → rocky-2
Changed in magnum-ui:
assignee: nobody → Shu Muto (shu-mutou)
status: New → In Progress
importance: Undecided → High
milestone: none → rocky-2
Changed in senlin-dashboard:
assignee: nobody → Shu Muto (shu-mutou)
status: New → In Progress
no longer affects: zaqar-ui

Reviewed: https://review.openstack.org/491349
Committed: https://git.openstack.org/cgit/openstack/zun-ui/commit/?id=da213880dca759baa7405440a8d95bc82e5fdda5
Submitter: Zuul
Branch: master

commit da213880dca759baa7405440a8d95bc82e5fdda5
Author: Shu Muto <email address hidden>
Date: Mon Aug 7 14:59:05 2017 +0900

    Reproduce navigations

    Details view does not reproduce side menu and breadcrumb properly
    by refreshing or linking directory.
    This patch fixes this issue.

    Change-Id: I13d9c8381a429caf7e7f4c984a7128faa764ad12
    Closes-Bug: #1746706
    Depends-On: I2edd44e55eb10114e5282cec1762e9635881f733

Changed in zun-ui:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/559636
Committed: https://git.openstack.org/cgit/openstack/senlin-dashboard/commit/?id=8929010fc340dbc4d5622a95566bb20c99055b5b
Submitter: Zuul
Branch: master

commit 8929010fc340dbc4d5622a95566bb20c99055b5b
Author: Shu Muto <email address hidden>
Date: Mon Apr 9 15:04:56 2018 +0900

    Reproduce navigations

    Details view does not reproduce side menu and breadcrumb properly
    by refreshing or linking directory.
    This patch fixes this issue.

    Change-Id: I43f673467893f82c6a8ab461488762a28c001399
    Closes-Bug: #1746706

Changed in senlin-dashboard:
status: In Progress → Fix Released
Changed in magnum-ui:
status: In Progress → Fix Released

Reviewed: https://review.openstack.org/559625
Committed: https://git.openstack.org/cgit/openstack/magnum-ui/commit/?id=33b730a33d8299782f3494fc5e2723322762d72c
Submitter: Zuul
Branch: master

commit 33b730a33d8299782f3494fc5e2723322762d72c
Author: Shu Muto <email address hidden>
Date: Mon Apr 9 14:02:05 2018 +0900

    Reproduce navigations

    Details view does not reproduce side menu and breadcrumb properly
    by refreshing or linking directory.
    This patch fixes this issue.

    Change-Id: Ice60cc61a990f1c5c9135992b91482ad7f2e6421
    Closes-Bug: #1746706

This issue was fixed in the openstack/horizon 14.0.0.0b1 development milestone.

This issue was fixed in the openstack/senlin-dashboard 0.9.0 release.

This issue was fixed in the openstack/magnum-ui 5.0.0 release.

This issue was fixed in the openstack/zun-ui 2.0.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers