ngdetail for non-existing resource type or resource ID does not return 404

Bug #1746709 reported by Akihiro Motoki on 2018-02-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
High
Shu Muto

Bug Description

After a fix for bug 1681627 is merged, when we open non-existing ngdetail page, "not found" page is not displayed.

There are two patterns.

(1) Non-existing resource ID for known resource type
  example: /ngdetails/OS::Glance::Image/<non-existing UUID>
  -> Error message popup is shown but "not found" page is not displayed.

(2) Unknown resource type
  example /ngdetails/OS::UNKNOWN/<something>
 -> No error message and "not found" page is displayed. A blank page with breadcrumb menu is shown.

In either case, "not found" page would be user-friendly I believe.

Akihiro Motoki (amotoki) on 2018-02-01
Changed in horizon:
importance: Undecided → High
status: New → Confirmed
milestone: none → rocky-2

Fix proposed to branch: master
Review: https://review.openstack.org/580103

Changed in horizon:
assignee: nobody → Shu Muto (shu-mutou)
status: Confirmed → In Progress

Change abandoned by Ivan Kolodyazhny (<email address hidden>) on branch: master
Review: https://review.openstack.org/580103
Reason: This review is > 4 months without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Reviewed: https://review.openstack.org/580103
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=58af8067966539dd3417f113e7356298b48386e5
Submitter: Zuul
Branch: master

commit 58af8067966539dd3417f113e7356298b48386e5
Author: Shu Muto <email address hidden>
Date: Wed Jul 4 15:53:03 2018 +0900

    Move to '404' page when resource type or resource not found

    When refresh or link directly to ngdetails without existing resource type
    or ID for the resource, ngdetails view shows blank view.

    This patch jump to 404 page in this situation.

    Change-Id: Ie95132d0fdb1e7aae5e32faad752f92ff76b238a
    Closes-Bug: #1746709

Changed in horizon:
status: In Progress → Fix Released

This issue was fixed in the openstack/horizon 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers