We made a small improvement to this if you wish to incorporate it.
if (proc.returncode & 187) != 0:
and
return 0 if (proc.returncode & 187) == 0 else proc.returncode
"Those would be smarter ways to do what we were wanting based similarly to what the munin guy is doing Now *ALLL* of the return codes 4, 64, and 68 will *ALL* return 0!!!
Not sure if you can update the bug with those lines as suggestions vs what I had before :confused:
This will also now always mask those errors so that when people see the return codes they can ignore the `4` and the `64` cause it won't even show in the exit code"
We made a small improvement to this if you wish to incorporate it.
if (proc.returncode & 187) != 0:
and
return 0 if (proc.returncode & 187) == 0 else proc.returncode
"Those would be smarter ways to do what we were wanting based similarly to what the munin guy is doing Now *ALLL* of the return codes 4, 64, and 68 will *ALL* return 0!!!
Not sure if you can update the bug with those lines as suggestions vs what I had before :confused:
This will also now always mask those errors so that when people see the return codes they can ignore the `4` and the `64` cause it won't even show in the exit code"