Re-enable after-commissioning actions
Bug #979539 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Low
|
Jeroen T. Vermeulen | ||
Bug Description
As per bug 979397 we're disabling UI references to after-commissioning actions for release. Once we go back go implementing meaningful choice there, we should re-enable the form fields, un-hide forms, and uncomment tests.
Search the source tree for disabled code marked with 979539 (this bug's number).
Related branches
lp:~jtv/maas/bug-979539
- Raphaël Badin (community): Approve
-
Diff: 389 lines (+63/-70)7 files modifiedsrc/maasserver/enum.py (+7/-9)
src/maasserver/forms.py (+14/-22)
src/maasserver/templates/maasserver/settings.html (+2/-4)
src/maasserver/templates/maasserver/snippets.html (+1/-2)
src/maasserver/tests/test_api.py (+28/-15)
src/maasserver/tests/test_forms.py (+6/-10)
src/maasserver/tests/test_views.py (+5/-8)
| description: | updated |
| tags: | added: ui |
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in maas: | |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
| status: | Triaged → In Progress |
Revision history for this message
| Julian Edwards (julian-edwards) wrote Re: [Bug 979539] Re: Re-enable after-commissioning actions | #2 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
For now, we want to re-enable this with just the one option that makes sense. That will force us to consider implications to the feature in whatever other changes we make, and will stop the code from rotting. But it's also slightly complicated by tests that hard-code a choice of “2.”