@seyeongkim hi, I'm working on sponsoring your patch right now.
I had to do some minor fixes in it:
1. Since we're adding delta in relation to Debian we should change version number to reflect that (e.g. 7.0-4ubuntu1).
2. The launchpad bug number has to follow the convention for the automation to correctly pick it up and close the bug automatically afterwards (i.e. LP: #1921658 and not "Closes: #1921658).
3. The patch header did not need the "+" signs in the beginning of the line.
4. There was a descriptive commit for one of the lines you backported (static int *local_prompt_newlines;) which you skipped. I think it should also be part of the backport as it explains why the variable is there in the first place.
@seyeongkim hi, I'm working on sponsoring your patch right now. prompt_ newlines; ) which you skipped. I think it should also be part of the backport as it explains why the variable is there in the first place.
I had to do some minor fixes in it:
1. Since we're adding delta in relation to Debian we should change version number to reflect that (e.g. 7.0-4ubuntu1).
2. The launchpad bug number has to follow the convention for the automation to correctly pick it up and close the bug automatically afterwards (i.e. LP: #1921658 and not "Closes: #1921658).
3. The patch header did not need the "+" signs in the beginning of the line.
4. There was a descriptive commit for one of the lines you backported (static int *local_
I'll update this bug if needed.
Thanks for the patch Seyeong!