Comment 4 for bug 1768911
Revision history for this message
| Jason Hobbs (jason-hobbs) wrote Re: curtin configuration for node during installation should be logged by default | #4 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
Blake,
I do not want to add more log collection code everytime we hit a new bug. Now that we're capturing both the DB and the maas logs for every run, that really should be sufficient.
To capture this output, I have to go and add some code to check and see if we have failed deployments, and then a API calls to grab the curtin config, and some more code to put the curtin somewhere it will get archived with the rest of the logs. That's fine, I'll do it because I want to get this bug fixed, but I consider it a workaround for something missing in maas and something we don't want to carry in our code base in the long run.
I've also seen the maas team ask lots of other people to go and capture curtin config to debug issues. Anyone using MAAS in a CI loop would have to implement the API calls I mentioned above in their own way. Anyone not using a CI loop might have already released the machines and moved on by the time you've asked for the config info. If it's a race condition, it might not be easy to reproduce again. All of that could be avoided if maas just persisted this stuff in the first place, like it does the curtin output. The curtin input is at least as important to persist as the output.