Comment 14 for bug 1423931

Thanks for the patch, and for helping to narrow the issue.

According to the documentation for claim_static_ips(), the DHCP host maps are supposed to be updated by the caller after the IP address has been claimed. In this case, I think the DHCP maps should have been updated when the IP address was initially claimed using the CLI, but were not. (which is why your workaround helps, so it can re-issue the claim again, when the node starts.)

There's a good argument to be made for claiming IP addresses at the last possible moment (when you're starting the node): there's less time for a potential race condition to occur. (for example, if you're running the cluster service on another machine, and that machine crashes and restores a backup before the node gets a chance to start)

As you point out, the current code calls claim_static_ip_addresses(), but doesn't find any claims. Note that it only checks for AUTO addresses, and upon not finding any, fails to update the DHCP server. (But in the current design, the DHCP server should have been updated already.)

I'll make some comments on the pull request.