Comment 3 for bug 1361897

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 1361897] Re: exceptions in PeriodicImageDownloadService will cause it to stop running

On Wednesday 27 August 2014 00:31:20 you wrote:
> It was not raising one specifically, but I have seen it raise one about
> the gpg key. I dont remember specifically what the name of the exception
> was.
>
> I think Gavin was just talking in general, it doesn't matter what
> exception, it will fail. Here is the review that this bug is
> referencing.
>
> https://code.launchpad.net/~blake-rouse/maas/rpc-import-> images/+merge/232271
>
> I think it would be nice to have a exception handling TimerService base
> class that just logs exceptions and keeps the timer service running.

Yeah agreed, thanks.

What we need is a base class that:

1. handles connection retries
2. other boilerplate for timer-based services that use RPC
3. handles errors and logs them without taking out the service loop