maas-import-pxe-files sets incorrect permissions for commissioning dir
Bug #1042865 reported by
Andres Rodriguez
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Gavin Panella |
Bug Description
maas-import-
ubuntu@
total 8
drwx------ 2 root root 4096 Aug 28 13:18 commissioning
drwxr-xr-x 2 root root 4096 Aug 28 13:11 install
Doing:
chmod 755 /var/lib/
Fixes the issue.
Related branches
lp:~andreserl/maas/maas_set_correct_file_permissions
- Julian Edwards (community): Needs Fixing
-
Diff: 33 lines (+5/-0)2 files modifiedsrc/provisioningserver/pxe/install_image.py (+1/-0)
src/provisioningserver/utils.py (+4/-0)
lp:~jtv/maas/bug-1042865
- Gavin Panella (community): Approve
-
Diff: 35 lines (+7/-4)1 file modifiedscripts/maas-import-ephemerals (+7/-4)
lp:~allenap/maas/tftp-permissions
- MAAS Maintainers: Pending requested
-
Diff: 14 lines (+4/-0)1 file modifiedscripts/maas-import-ephemerals (+4/-0)
lp:~allenap/maas/maas-set-correct-file-permissions
- Scott Moser (community): Approve
-
Diff: 83 lines (+26/-7)3 files modifiedscripts/maas-import-ephemerals (+0/-7)
src/provisioningserver/pxe/install_image.py (+8/-0)
src/provisioningserver/pxe/tests/test_install_image.py (+18/-0)
Changed in maas: | |
importance: | Undecided → Critical |
Changed in maas: | |
status: | New → Triaged |
Changed in maas: | |
assignee: | nobody → Jeroen T. Vermeulen (jtv) |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
Changed in maas: | |
status: | New → In Progress |
assignee: | Jeroen T. Vermeulen (jtv) → Gavin Panella (allenap) |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
The directory is created in the make_destination function in src/provisionin gserver/ pxe/install_ image.py. It looks like the umask is too strict here, so the code should be more defensive and explicitly set the permissions it needs.