Comment 6 for bug 315511

Revision history for this message
Noah Slater (nslater) wrote : Re: [Bug 315511] Re: lxml.html.diff gives peculiar diffs

On Tue, Apr 07, 2009 at 04:19:42AM -0000, Ian Bicking wrote:
> Well, I would have just committed it if I thought it was entirely okay.
> OTOH, the diff it produces isn't *entirely* wrong, it just isn't good
> HTML. It would be a valid diff if you ignored the way HTML works.

This is a HTML diff function, so producing invalid HTML seems like a fundamental
problem. It seems almost absurd to argue that this could be considered correct
behaviour, if only you ignore how HTML works. This module is, without doubt, the
best tool for working with HTML and XML in Python, but it worries me that such a
position could even be considered. I'm not trivialising the work involved in
this, and I certainly don't think I could successfully maintain and improve this
library, but if this is supposed to be used with HTML, but I would expect the
baseline of quality assurance to be valid output.

--
Noah Slater, http://tumbolia.org/nslater