X01-localapps pathologically slow with many groups
Bug #357268 reported by
Dan Young
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
LTSP5 |
Fix Released
|
Low
|
Alkis Georgopoulos | ||
ltsp (Debian) |
Fix Released
|
Undecided
|
Unassigned | ||
ltsp (Ubuntu) |
Fix Released
|
Medium
|
Unassigned |
Bug Description
With non-trivial numbers of users/groups (e.g. when the server LDAP authenticates), X01-localapps takes many, many minutes to return, blocking the session from starting.
The attached patch rewrites the portion of the shell script that does the group deduplication in awk.
tags: | added: ltsp-client-core |
affects: | ubuntu → ltsp (Ubuntu) |
affects: | debian → ltsp (Debian) |
Changed in ltsp (Ubuntu): | |
status: | Confirmed → Triaged |
importance: | Undecided → Medium |
To post a comment you must log in.
Is the current code still slow for you?
I remember us doing multiple iterations of that specific scripts to try to get it right (both properly parsing complex group names and being fast at the same time).
I don't necessarily have something against rewriting it in awk but experience showed that this specific script is very fragile and we can't easily regression test it, so the least we change it, the better.