Comment 6 for bug 745738

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 3/31/2011 5:21 AM, Robert Collins wrote:
> Failed again; I'm backing out the patch to run the loggerhead tests on
> changes to LP; we don't generally do this now, and choosing this route
> multiplies any fragility together; I think we should find a different
> way to be confident loggerhead works with the very of bzr launchpad
> uses.
>

If it is just the one test, it is pretty easy to change the test *as I
described* and have it pass regularly rather than back it out. I realize
the test itself was fragile, you could set the timeout to 60min if you
are unhappy. The point was that if the test was every broken (by a
real-bug somewhere) I didn't want it to block indefinitely waiting to
find that bug.

In this case, it is giving false positives, so should be set to a higher
timeout threshold.

I'm pretty sure this isn't the first flaky test that has been landed in
the launchpad test suite. I'm not sure why you felt the need to ignore
the advice I posted here and back out all of the loggerhead tests.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2UDisACgkQJdeBCYSNAAM7SgCfS4mjNrdCB6plIh9qmxZlMrI1
A3QAn21Nh/qz/fjkrmBbU3dncIUzZ/sZ
=tU5C
-----END PGP SIGNATURE-----