Bloom filter error

Bug #458498 reported by Pirre
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
DC++
High
Unassigned
LinuxDC++
High
Unassigned

Bug Description

Hub: [Incoming][*************************] IGET blom / 0 8 BK8 BH24
Hub: [Outgoing][************************] CSTA 250 Unsupported\sm

To reproduce

Sit in the hub with no shares, make a folder with a smal file, add it to shares ...... and a disconnect follows in every adch hub you are in :)

Revision history for this message
Sulan (sulan80) wrote :

So this is whats been happening to me in public dev :P

Changed in adchpp:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Jacek Sieka (arnetheduck) wrote :

In reality this is a bug in DC++ (it should accept the supplied m as it's being correctly rounded and therefore is reasonable

That said, disconnecting the user for failing to supply a blom is a bit harsh...

Revision history for this message
Sulan (sulan80) wrote :

As of DC++ 1886 i'm no longer disconnected when sharing small files. I would consider this fixed.

Revision history for this message
Sulan (sulan80) wrote :

Client::onConnected
<incoming HSUP ADBAS0 ADBASE ADTIGR ADBLO0
OCFF entering IDENTIFY
>Outgoing ISID OCFF
<incoming BINF OCFF IDE7EALOQGQVHFQ4NIGVEBTB3JMBJGOUBMIPPVYYI PDZP4UB42Y765DKMYN
NPLNHVZO5SSL5RUWQEZVJMY NIsulan SL5 SS118 SF1 HN2 HR1 HO1 VE++\s0.707 US52428 I4
0.0.0.0 U46665 SUADC0,TCP4,UDP4
>Outgoing IGET blom / 0 8 BK8 BH24
OCFF verifying ip
Skipping local ip 127.0.0.1
OCFF verifying CID
OCFF verifying nick
OCFF entering NORMAL
Client::onData: CSTA 250 Unsupported\sm

Client::onData invalid SID
Client::disconnect type: 7
Removing OCFF
ManagedSocket deleted

Revision history for this message
Sulan (sulan80) wrote :

what im trying to show is that ADCH++ try to extract SID from CSTA and fails.

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

Yeah, I fixed it yesterday (I think...)

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

This is all dc++'s fault...

Changed in adchpp:
status: Confirmed → Invalid
Changed in dcplusplus:
importance: Undecided → High
status: New → Fix Committed
Revision history for this message
Sulan (sulan80) wrote :

Is it resonable to consider CSTA from a client fatal?

Revision history for this message
FlipFlop™ (flup-flop) wrote :

Shouldn't it be a HSTA as reply to IGET, C should only be used in c-c connections if i'm not mistaken

Revision history for this message
poy (poy) wrote :

Fixed in version 0.760.

Changed in dcplusplus:
status: Fix Committed → Fix Released
Revision history for this message
Toast (swetoast-deactivatedaccount) wrote :

[15:17] <Toast> think sulan was the inital reporter
[15:17] <razzloss> yeah, found it. https://bugs.launchpad.net/dcplusplus/+bug/458498 and fixed in 0.760
[15:18] <razzloss> so not in linuxcdpp
[15:18] <Toast> https://bugs.launchpad.net/dcplusplus/+bug/458498
[15:18] <Toast> bingo
[15:18] <Toast> might wanna add those fixes
[15:18] <Toast> perhaps we should dual report these serious fixes to linuxdcpp also
[15:20] <Toast> there
[15:21] <Toast> assigned the bug to linuxdcpp

sry if we been sloppy with dual reporting guys :)

affects: dcplusplus → linuxdcpp
Changed in linuxdcpp:
status: Fix Released → New
affects: adchpp → dcplusplus
Changed in dcplusplus:
status: Invalid → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers