Bloom filter error

[Pirre]

Hub: [Incoming][*************************] IGET blom / 0 8 BK8 BH24
Hub: [Outgoing][************************] CSTA 250 Unsupported\sm

To reproduce

Sit in the hub with no shares, make a folder with a smal file, add it to shares ...... and a disconnect follows in every adch hub you are in :)

[Sulan (sulan80)]

So this is whats been happening to me in public dev :P

[Jacek Sieka (arnetheduck)]

In reality this is a bug in DC++ (it should accept the supplied m as it's being correctly rounded and therefore is reasonable

That said, disconnecting the user for failing to supply a blom is a bit harsh...

[Sulan (sulan80)]

As of DC++ 1886 i'm no longer disconnected when sharing small files. I would consider this fixed.

[Sulan (sulan80)]

Client::onConnected
<incoming HSUP ADBAS0 ADBASE ADTIGR ADBLO0
OCFF entering IDENTIFY
>Outgoing ISID OCFF
<incoming BINF OCFF IDE7EALOQGQVHFQ4NIGVEBTB3JMBJGOUBMIPPVYYI PDZP4UB42Y765DKMYN
NPLNHVZO5SSL5RUWQEZVJMY NIsulan SL5 SS118 SF1 HN2 HR1 HO1 VE++\s0.707 US52428 I4
0.0.0.0 U46665 SUADC0,TCP4,UDP4
>Outgoing IGET blom / 0 8 BK8 BH24
OCFF verifying ip
Skipping local ip 127.0.0.1
OCFF verifying CID
OCFF verifying nick
OCFF entering NORMAL
Client::onData: CSTA 250 Unsupported\sm

Client::onData invalid SID
Client::disconnect type: 7
Removing OCFF
ManagedSocket deleted

[Sulan (sulan80)]

what im trying to show is that ADCH++ try to extract SID from CSTA and fails.

[Jacek Sieka (arnetheduck)]

Yeah, I fixed it yesterday (I think...)

[Jacek Sieka (arnetheduck)]

This is all dc++'s fault...

[Sulan (sulan80)]

Is it resonable to consider CSTA from a client fatal?

[FlipFlop™ (flup-flop)]

Shouldn't it be a HSTA as reply to IGET, C should only be used in c-c connections if i'm not mistaken

[poy (poy)]

Fixed in version 0.760.

[Toast (swetoast-deactivatedaccount)]

[15:17] <Toast> think sulan was the inital reporter
[15:17] <razzloss> yeah, found it. https://bugs.launchpad.net/dcplusplus/+bug/458498 and fixed in 0.760
[15:18] <razzloss> so not in linuxcdpp
[15:18] <Toast> https://bugs.launchpad.net/dcplusplus/+bug/458498
[15:18] <Toast> bingo
[15:18] <Toast> might wanna add those fixes
[15:18] <Toast> perhaps we should dual report these serious fixes to linuxdcpp also
[15:20] <Toast> there
[15:21] <Toast> assigned the bug to linuxdcpp

sry if we been sloppy with dual reporting guys :)