Comment 14 for bug 442475

aww, what did Steven do? He was against the whole idea.

Anyway back to the subject. Of course you're right, if we moved the duplicate checking to ::on function results map wouldn't need to be accessed from the _gui and it could be used within the other _client functions. Though I'd still rather dispatch a SearchResultPtr instead of StringMap and convert the pointer to presentable strings in _gui (because ptr is just much lighter to pass around than the map (I don't know if this has that big of an effect on performance, I'll have to check)).

And at the same note, I don't think that changing the _client functions to use results map instead of findUser has that big of an effect on performance since the client functions are called from user actions and thus are quite rare (compared to addResult).

But that being said, I'll move the duplicate check to _client and remove the findUser calls. Depending on performance measurement results I'll change the StringMap passing back also.

--RZ