Comment 9 for bug 321246

Revision history for this message
Jacek Sieka (arnetheduck) wrote :

Removing the dcassert sounds fine
Converting in nmdchub sounds fine as long as the binary nick thing is done
Validating the utf8 meant for display also sounds fine, assuming we replace any bad chars as opposed to discarding the whole message...or at least that seems like the most reasonable tradeoff unless you have a better idea?

I don't remember the code but I'm guessing most out-of-nmdc-conversions are done either in protocolspecific bits (search results?) or would go away were the binary nick thing implemented...in any case keeping it in nmdchub makes a lot of sense.