Comment 20 for bug 311818

Revision history for this message
poy (poy) wrote :

rev 3158: re-hashing won't actually be necessary on Windows >= Vista (as long as hashed files don't have a case-insensitive dupe, which is very unlikely on Windows).

i have also been able to test downloading with the above changes; everything seems to be going smoothly. :)

notes for Linux devs:
- make sure the same files are always renamed after a share refresh; otherwise, "file not found" errors are going to pop on peers trying to download renamed files. this is not an issue on Windows because the directory iterator always reads directories in the same order (eg A.txt always comes before a.txt, so a.txt will always be the one to be renamed to "a (1).txt"); but i don't know if opendir/readdir etc respect that on Linux.
- try to implement the hash upgrading logic in dcpp/HashManager.cpp:431, function upgradeFromV2. it's been left as a todo for now.