Comment 8 for bug 298894

Revision history for this message
Steven Sheehy (steven-sheehy) wrote :

>I've let it slip earlier, but please don't change things and commit them under my name.

I usually edit patches myself to fit them to coding standards, add comments, improve code readability, etc. It is my responsibility as maintainer to ensure the code is clear and consistent. It is generally quicker to change them myself than to ask the submitter to change them, but I can understand what you mean. In the future I will try to force patch writers to fix their own patches and if it does not meet my expectations I will reject it. On the other hand, I expect patch writers like yourself to follow the coding standards more closely.

> Hmm. How about "Default hub encoding" (as it actually says in the Preferences)? It would probably be nicer if things > that *are* the same thing are *called* the same thing. ;-)

I didn't choose "Default hub encoding" because it would be redundant to have encoding twice, once for the label and once inside the drop down box. "Encoding: Default hub encoding" sounds silly.