Comment 21 for bug 298894

Revision history for this message
Steven Sheehy (steven-sheehy) wrote :

2) Actually, I didn't even notice that the two GtkTables weren't aligned since the difference was very slight. It should be fine to use a single GtkTable then. I would just like to see it slimmed down to two columns and use some other means to indent the text entry labels like xpad.
5) I'm not sure using N_() will work for that purpose. It would cause it to not break the first time after people upgrade, but it would also cause it to not work for subsequent times if you store the ENCODING_DEFAULT translated text in Favorites.xml. If you don't store the translated text it should be fine, but then people can't edit their Favorites.xml by hand. We're probably going to have other breakage due to internationalizing, so we shouldn't necessarily sacrifice keeping the code as simple as possible. Just give the users a warning to backup beforehand.