Comment 11 for bug 298894

Revision history for this message
qwertitis (qwertitis-deactivatedaccount) wrote :

@steven: Yes, my thoughts exactly

@zamanian: Well, you could have suggested this to me one week ago when I had written the patch instead of waiting until now, or didn't you realize I had implemented this? What you're calling for is to remove the special list item from fav hubs totally. Which kind of makes sense in one way -- but will strand us up with a lot of "i've changed the setting (in prefs) but nothing's changed" questions regarding connecting to hubs (fav'd obviously).

I called the fav-hub list item "User preference" (in my branch) because that is what it is. Global hub default sounds like some world-global defacto standard, and "default hub encoding" -- it isn't default (as in "factory setting") - the value depends on your preference.

I can also suggest that we remove the list item from fav hubs and add a checkbox instead: "Override user preference". Same semantics as current branch, different interface. This would be easier to i18nize too ;)