Comment 123 for bug 160413

Success! I managed to get it working for both S5 and S3 some hours ago. :)

My "fix" was to comment out the following four lines in rtl8169_suspend():

        spin_lock_irq(&tp->lock);

        rtl8169_asic_down(ioaddr);

        rtl8169_rx_missed(dev, ioaddr);

        spin_unlock_irq(&tp->lock);

Also, I commented out setting a shutdown handler.

This is probably not the best fix ever but I am quite satisfied as I can now go to S5 (shutdown -h now) and also S3 (pm-suspend) and wake from both those states multiple times without any side effect as far as I can tell.

Anyway to answer some of Bruno's questions:

Yes, before this "fix" WoL for "any phy activity" worked but not for magic packet.

In dmesg I find the following on my network cards (the AB9 Pro has two):

[ 12.671231] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
[ 12.671247] r8169 0000:03:00.0: PCI INT A -> GSI 18 (level, low) -> IRQ 18
[ 12.671272] r8169 0000:03:00.0: setting latency timer to 64
[ 12.671298] r8169: mac_version = 0x0c
[ 12.671616] eth0: RTL8168b/8111b at 0xffffc20000c34000, 00:50:8d:95:27:6a, XID 38000000 IRQ 2298
[ 12.671619] r8169: mac_version = 0x0c
[ 12.673028] r8169 Gigabit Ethernet driver 2.3LK-NAPI loaded
[ 12.673042] r8169 0000:04:00.0: PCI INT A -> GSI 16 (level, low) -> IRQ 16
[ 12.673054] r8169 0000:04:00.0: setting latency timer to 64
[ 12.673078] r8169: mac_version = 0x0c
[ 12.673385] eth1: RTL8168b/8111b at 0xffffc20000c36000, 00:50:8d:95:27:6b, XID 38000000 IRQ 2297
[ 12.673387] r8169: mac_version = 0x0c

lspci gives me:

03:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168B PCI Express Gigabit Ethernet controller (rev 01)
04:00.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL8111/8168B PCI Express Gigabit Ethernet controller (rev 01)

lspci -n give me:

03:00.0 0200: 10ec:8168 (rev 01)
04:00.0 0200: 10ec:8168 (rev 01)

Bruno, with this information, do you still believe it to be related to the MAC address not being properly configured??

Shutting down the box and then pulling and re-attaching the power cord leaves it unresponsive to WOL magic packets I'm afraid.

I would gladly see this bug through to a more solid fix. At least it now seems that the issue has been narrowed down quite a bit, am I right?

As I mentioned I am kind of new to this so any suggestions would be appreciated.