Comment 9 for bug 868550
Revision history for this message
| Arnd Bergmann (arnd-arndb) wrote Re: [Bug 868550] [GIT PULL] Avoid #ifdef __linux__ misuse in exportable headers | #9 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
e3ace39
(Get the code!)
On Thursday 06 October 2011, Dave Martin wrote:
> Can someone give this a try?
>
> For now, I've only attempted to touch headers that look like
> they are expoerted to userspace.
I've looked at the patch and found small typos:
-#if defined(__linux__)
+#if define (__linux_kernel__) || defined(__linux__)
^^^^^^
-#ifndef __KERNEL__
+#ifndef __liunx_kernel__
^^^^^
More importantly, it's not at all clear from the description why you are
even doing this. If the android toolchain does not set __linux__, this
sounds more like a bug in the android toolchain. I would expect much
more stuff to break because of that.
Arnd