Restrict downloads to system and uboot images

Bug #885819 reported by Mathieu Poirier
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro Android Frontend
Fix Released
Critical
Данило Шеган
Linaro Fetch Image
Won't Fix
High
James Tunnicliffe
linaro-landing-team-samsung
Fix Released
Undecided
Unassigned
linaro-websites
Fix Released
Critical
Данило Шеган

Bug Description

We need to make the access to snowball system/uboot snowball images restricted by the license similarly to what is already done on igloocommunity.org. We want to ensure that people have clicked through the license before being able to download even if they are not coming through the starting page on android-build.linaro.org build page itself (like https://android-build.linaro.org/builds/~linaro-android/staging-snowball/).

We need to do the same thing for android-build jenkins instance.

Having a flag to easily turn on or off license click-through requirement would work wonders :)

Revision history for this message
Mathieu Poirier (mathieu.poirier-deactivatedaccount) wrote :

It would be nice to have this by November 24th as agreed with Danilo.

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

See also lp:887147

Revision history for this message
Mattias Backman (mabac) wrote :

To be able to remove the click through license from the (non Android) hwpacks we need to add the same restriction to releases.linaro.org, snapshots.linaro.org and wherever else we can download hwpacks from.

Possibly also some change to linaro-fetch-image(-ui) since that can download hwpacks without user intervention. So I'll add l-i-t as well then. :)

Changed in linaro-android-frontend:
importance: Undecided → Critical
assignee: nobody → Данило Шеган (danilo)
Changed in linaro-android-frontend:
status: New → Triaged
Changed in linaro-image-tools:
status: New → Triaged
Changed in linaro-websites:
status: New → Triaged
Changed in linaro-image-tools:
importance: Undecided → Critical
Changed in linaro-websites:
importance: Undecided → Critical
Changed in linaro-image-tools:
assignee: nobody → Данило Шеган (danilo)
Changed in linaro-websites:
assignee: nobody → Данило Шеган (danilo)
Revision history for this message
Anmar Oueja (anmar) wrote :

Can we get a list of all the locations these images may exist at. Currently, I have:

- PPA(s)
- releases.linaro.org
- snapshots.linaro.org

What about the temp places that the build systems use to build stuff?

Revision history for this message
Fathi Boudra (fboudra) wrote :

The build service is Offspring, it pulls packages from PPA. Once the build is done, the hardware packs are copied on snapshots.linaro.org.

Revision history for this message
Mathieu Poirier (mathieu.poirier-deactivatedaccount) wrote :
Revision history for this message
Anmar Oueja (anmar) wrote :

This bug is related to the overall effort #887147.

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

The temp place that the build system uses is still private, and we also don't have access to them.

Usually when we create a new build project at offspring we create a RT to enable the automatic sync between the build server and snapshots.linaro.org. If the private hwpack is working properly already, then we'd just the to request the sync between the build server and the special place that has the click through interface.

That should be all from the Ubuntu side, we just need to check then how the private packages are available for the hwpacks, like having a private PPA (don't yet know the technical requirements from this side).

Anmar Oueja (anmar)
Changed in linaro-landing-team-ste:
milestone: none → 2011.12
assignee: nobody → Mathieu Poirier (mathieu.poirier)
status: New → Confirmed
importance: Undecided → Critical
Usman Ahmad (usman-ah)
Changed in linaro-landing-team-samsung:
milestone: none → 2011.12
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

I would like to list exact places from which build downloads are available on https://android-build.linaro.org . Below, I give exact URLs representing the URL patterns we have in use. Some parts in them are dynamic of course (job name, build number, file name).

1. https://android-build.linaro.org/jenkins/job/linaro-android_panda/416/artifact/build/out/target/product/pandaboard/system.tar.bz2
2. http://android-build.linaro.org/builds/~linaro-android/panda/416/target/product/pandaboard/system.tar.bz2
3. https://android-build.linaro.org/builds/~linaro-android/panda/416/output/build/out/target/product/pandaboard/system.tar.bz2

#1 is Jenkins internal link (served by Jenkins, proxied by Apache), #2 & #3 are our frontend links, served by Apache directly off filesystem. And #3 is not really produced on any page any longer for few months, it is legacy one which used to be shown in one very obscure place, and I'm 99.9% positive that it wasn't posted anywhere. So, good solution would be to remove support for it altogether, then we'd have to maintain only 1 frontend link (+1 implicit jenkins' one). For the frontend link, we could use .htaccess to add needed rewrite/redirect magic, and that would be scalable solution (no need to patch central config), but that won't work for #1, which is internal "virtual" Jenkins link, so it would need to be handled by central Apache config file (of course, we can produce include file specifically for click-thru redirects).

And final note - all above is pertinent if EULA-protected builds will be still served from https://android-build.linaro.org/ . (But secure not-hosting them on https://android-build.linaro.org/ is a task on its own.)

Revision history for this message
Anmar Oueja (anmar) wrote :

Danilo and the infrastructure team did an amazing job in providing the necessary support for this to happen in time for 2011.12 release.

Changed in linaro-landing-team-ste:
status: Confirmed → Fix Committed
Revision history for this message
Данило Шеган (danilo) wrote :

We might need to fix fetch-image* stuff to go through the click-through properly (i.e. show the license text).

Changed in linaro-android-frontend:
milestone: none → 11.12
Changed in linaro-image-tools:
status: Triaged → Won't Fix
status: Won't Fix → Triaged
importance: Critical → High
assignee: Данило Шеган (danilo) → nobody
Changed in linaro-android-frontend:
status: Triaged → Fix Released
Changed in linaro-image-tools:
milestone: none → 12.01
Changed in linaro-websites:
status: Triaged → Fix Released
Anmar Oueja (anmar)
Changed in linaro-landing-team-ste:
status: Fix Committed → Fix Released
Changed in linaro-landing-team-samsung:
status: New → Fix Released
Mattias Backman (mabac)
Changed in linaro-image-tools:
milestone: 12.01 → 12.02
Fathi Boudra (fboudra)
Changed in linaro-image-tools:
milestone: 2012.02 → 2012.03
Revision history for this message
James Tunnicliffe (dooferlad) wrote :

Have taken the linaro-image-tools bit and changed it to linaro-fetch-image since it would appear the only missing bit is that linaro-fetch-image doesn't support displaying the license to the user so they can accept it.

It would be nice to cache license acceptance. Is it OK to download a copy of the license when the user accepts it and assume that if the license doesn't change, the user doesn't need to accept it again (download the license every time, if the license downloaded matches one that has been accepted, doen't ask the user to accept it again)?

Changed in linaro-image-tools:
assignee: nobody → James Tunnicliffe (dooferlad)
affects: linaro-image-tools → linaro-fetch-image
Changed in linaro-fetch-image:
milestone: 2012.03 → none
Milo Casagrande (milo)
Changed in linaro-fetch-image:
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.