binaries: on unzip, top-level dir contains Windows-hostile characters

[Bernie Ogden]

Windows appears to dislike both '~' and '+' characters. This can be awkward to work with on a Windows cmd prompt, but is OK so long as you enquote the directory name. Spun out from bug 894528 as that is really about the more serious problem of not running from a path that contains spaces. This is more of a mild pain that should be fixed if it is convenient to format the version string differently.

Examples:

1) Copy/paste of path fails:
C:\>copy C:\linarogcc\gcc-linaro-arm-linux-gnueabi-2012.01-20120112+bzr2336~win3
2\arm-linux-gnueabi\bin\ar.exe Y:\
The system cannot find the file specified.

2) Enquoted path works:
C:\>copy "C:\linarogcc\gcc-linaro-arm-linux-gnueabi-2012.01-20120112+bzr2336~win
32\arm-linux-gnueabi\bin\ar.exe" Y:\
        1 file(s) copied.

3) Renamed path works without quotes:
C:\>copy C:\linarogcc\gcc-linaro-arm-linux-gnueabi-2012.01-20120112-bzr2336-win3
2\arm-linux-gnueabi\bin\ar.exe Y:\
Overwrite Y:\ar.exe? (Yes/No/All): y
        1 file(s) copied.

[Michael Hope (michaelh1)]

Agreed. I changed the ~ to _ for the release. It's more Debian like in any case.

[Bernie Ogden (bogden)]

Windows isn't keen on the '+' either:

C:\Program Files\DS-5\bin>copy C:\linarogcc\gcc-linaro-arm-linux-gnueabi-2012.01
-20120112+bzr2336-win32\arm-linux-gnueabi\bin\ar.exe Y:\
The system cannot find the file specified.

C:\Program Files\DS-5\bin>copy "C:\linarogcc\gcc-linaro-arm-linux-gnueabi-2012.0
1-20120112+bzr2336-win32\arm-linux-gnueabi\bin\ar.exe" Y:\
        1 file(s) copied.

[Michael Hope (michaelh1)]

Yip. I'm very reluctant to lose the '+bzr' as it's Debian style and we use it across every other product.

Note that the + only appears in development builds.

[Bernie Ogden (bogden)]

If it only affects development builds then I think it's fine as is.