Comment 1 for bug 1018141

Revision history for this message
warmcat (andy-warmcat) wrote :

Dave it's complaining about the kzalloc in omap2_dpll_round_rate() which you added to generate the rate cache.

Actually I don't know what it's complaining about exactly except somehow it's a "bad time to do kzalloc()", and it's the only code that triggers the problem.

Since there are only a handful of discrete frequencies, I guess you should make a patch which adapts this code to use a static array of struct dpll_rate_list and a static "high water mark" replacing kzalloc. If it reaches the size of the array, just don't cache the result any more. Or, if you can see what the actual complaint is really about attacking it that way is also an option.