Comment 6 for bug 913819

Revision history for this message
Mattias Backman (mabac) wrote : Re: [Bug 913819] Re: Add an option to linaro-android-media-create to pass in additional bootargs

On Wed, Jan 25, 2012 at 11:42 AM, Amit Pundir <email address hidden> wrote:
> Not sure if it is the correct way to handle this but the following
> change in linaro-image-tools (rev 485) worked for me.
>
> $ bzr diff
> === modified file 'linaro_image_tools/media_create/boards.py'
> --- linaro_image_tools/media_create/boards.py   2012-01-18 15:27:35 +0000
> +++ linaro_image_tools/media_create/boards.py   2012-01-25 10:01:31 +0000
> @@ -577,7 +577,7 @@
>     @classmethod
>     def add_boot_args(cls, extra_args):
>         if extra_args is not None:
> -            cls.extra_boot_args_options += ' %s' % extra_args
> +            cls.extra_boot_args_options = ' %s' % extra_args

Obviously you'd loose the extra args set in the hwpack or defaults in
l-m-c. Guileherme's fix handles the extra args being None for some
boards correctly.

>
>     @classmethod
>     def add_boot_args_from_file(cls, path):
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/913819
>
> Title:
>  Add an option to linaro-android-media-create to pass in additional
>  bootargs
>
> Status in Linaro Android:
>  New
> Status in Linaro Image Tools:
>  In Progress
>
> Bug description:
>  We need an option to linaro-android-media-create to pass in additional
>  boot args. The option should take a file name or a string (could be
>  two different options).
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-android/+bug/913819/+subscriptions