On Tue, 29 Mar 2011 19:33:39 -0000, Mattias Backman <email address hidden> wrote:
> Hi James,
>
> It seems like both Eric and I got the same idea, but there's no real
> reason behind doing it exactly like this.
>
> The prefix parameter came from '%s/vmlinuz-*-' (and '%s/initrd.img-*-')
> being concatenated with all the regexps. I chose between letting
> _get_file_matching handle the concatenation or having make_uImage and
> make_uInitrd do it before calling that function. I could just as well
> supply _get_file_matching with a list of pre-concatenated regexps and
> that probably makes more sense when reading the code.
Ah ok. That I don't mind too much then, I assumed they were coming
straight from the BoardConfig classes.
I'm happy with which ever way you think is better.
> I'll push an update in the morning and propose a merge.
On Tue, 29 Mar 2011 19:33:39 -0000, Mattias Backman <email address hidden> wrote:
> Hi James,
>
> It seems like both Eric and I got the same idea, but there's no real
> reason behind doing it exactly like this.
>
> The prefix parameter came from '%s/vmlinuz-*-' (and '%s/initrd.img-*-')
> being concatenated with all the regexps. I chose between letting
> _get_file_matching handle the concatenation or having make_uImage and
> make_uInitrd do it before calling that function. I could just as well
> supply _get_file_matching with a list of pre-concatenated regexps and
> that probably makes more sense when reading the code.
Ah ok. That I don't mind too much then, I assumed they were coming
straight from the BoardConfig classes.
I'm happy with which ever way you think is better.
> I'll push an update in the morning and propose a merge.
Great.
Thanks,
James