Comment 6 for bug 744857

Revision history for this message
Mattias Backman (mabac) wrote :

Hi James,

It seems like both Eric and I got the same idea, but there's no real reason behind doing it exactly like this.

The prefix parameter came from '%s/vmlinuz-*-' (and '%s/initrd.img-*-') being concatenated with all the regexps. I chose between letting _get_file_matching handle the concatenation or having make_uImage and make_uInitrd do it before calling that function. I could just as well supply _get_file_matching with a list of pre-concatenated regexps and that probably makes more sense when reading the code.

About the comma separated string. Well, I just got stuck on lool's suggestion in the description and kind of thought that the board configs are plain text config files even when reading the code. Of course it should be a list of strings.

I'll push an update in the morning and propose a merge.

Thanks,

Mattias