Comment 5 for bug 744857

Revision history for this message
James Westby (james-w) wrote :

Hi Mattias,

Thanks for looking at this.

The direction of the change looks good to me, but I'm a little unsure about the specifics.

It's not clear to me why you added the prefix parameter. It seems obscure to me, and if
code wants to have a common prefix that they don't release, they can do that in code
somehow. Maybe I'm missing something here though.

The other thing that's not clear to me is why to prefer comma-separated strings, rather
than a list of strings. The latter is more obvious, and doesn't have a problem if someone
wants a comma in the regex.

As I said, I may be missing something, so please tell me if so.

I suggest that you propose your changes for merging as I'm sure we can come to a
resolution quickly for this change.

Thanks,

James