Linaro Image Tools

Should install btrfs-tools if missing

Bug #715932 reported by Loïc Minier
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Linaro Image Tools
Fix Released
Medium
Loïc Minier

Bug Description

Hi

Other Debian-ish installers install the relevant deps when creating the rootfs; for instance d-i and ubiquity install btrfs-tools when creating a btrfs rootfs (via partman-btrfs). This will provide things like fsck.btrfs and tools to use other btrfs features like snapshots etc.

We should do the same; this might require network access (as other things might), unless already installed in the image.

ext2/3/4 are included because e2fsprogs is Essential: yes.

Cheers,

Related branches

lp:~lool/linaro-seeds/add-btrfs-tools
Rejected for merging into lp:linaro-seeds/natty
Steve Langasek (community): Disapprove
Diff: 9 lines (+1/-1)
1 file modified
linaro-headless (+1/-1)
lp:~lool/linaro-image-tools/btrfs-support
Guilherme Salgado (community): Approve
Diff: 467 lines (+173/-39)
7 files modified
linaro-media-create (+9/-3)
linaro_image_tools/cmd_runner.py (+7/-1)
linaro_image_tools/media_create/chroot_utils.py (+31/-7)
linaro_image_tools/media_create/rootfs.py (+13/-3)
linaro_image_tools/media_create/tests/test_media_create.py (+101/-25)
linaro_image_tools/tests/fixtures.py (+4/-0)
linaro_image_tools/tests/test_cmd_runner.py (+8/-0)
lp:linaro-image-tools/11.11
Revision history for this message
Loïc Minier (lool) wrote :

It might be that we also decide to include btrfs-tools by default in our rootfses, but that's unrelated.

Revision history for this message
Loïc Minier (lool) wrote :

s/unrelated/orthogonal/ :-)

James Westby (james-w)
Changed in linaro-image-tools:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Alexander Sack (asac) wrote :

Please hold back on this change for now.

l-m-c must not require network for hwpacks created with include-debs option. We need a better solution than installing it on demand from the net in l-m-c. e.g. before discussing fixing this in l-m-c we have to explore all options we have on image side of things.

Revision history for this message
Loïc Minier (lool) wrote :

Why do we need to hold on this change? Nothing will be installed if the rootfs already has btrfs-tools, and installing btrfs-tools if the rootfs doesn't have it is the correct thing to do, isn't it? I'm not sure why you want to delay this, it's orthogonal to the seeds discussion

Loïc Minier (lool)
Changed in linaro-image-tools:
status: Triaged → In Progress
assignee: nobody → Loïc Minier (lool)
Loïc Minier (lool)
Changed in linaro-image-tools:
status: In Progress → Fix Committed
Loïc Minier (lool)
Changed in linaro-image-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.