It's not failing because umount returns non-zero, it's failing because cleanup_tempdir() is broken; it passes as_root to cmd_runner.Popen(), which doesn't expect that argument. We definitely need some tests for cleanup_tempdir()
It's not failing because umount returns non-zero, it's failing because cleanup_tempdir() is broken; it passes as_root to cmd_runner.Popen(), which doesn't expect that argument. We definitely need some tests for cleanup_tempdir()