Comment 4 for bug 845642

Revision history for this message
vishal (vishalbhoj) wrote : Re: ADB does not work on beagle-11.09-release build 2

There was a patch to fix the issue but it looks like its not the right way to fix the issue. Here the mail reply on the patch

Felipe Balbi to Vishalbhoj

show details 4 Oct (7 days ago)

Hi,
- Hide quoted text -

On Mon, Oct 03, 2011 at 08:33:41PM +0400, Vishal Bhoj wrote:
> From: Vishal Bhoj <email address hidden>
>
> This check is needed since, suspend is getting called even after
> resume.This makes sure that its not pushed to suspend in resume
> case
>
> Signed-off-by: Vishal Bhoj <email address hidden>
> ---
> drivers/usb/otg/twl4030-usb.c | 6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/usb/otg/twl4030-usb.c b/drivers/usb/otg/twl4030-usb.c
> index efeb4d1..7d7606a 100644
> --- a/drivers/usb/otg/twl4030-usb.c
> +++ b/drivers/usb/otg/twl4030-usb.c
> @@ -552,6 +552,12 @@ static int twl4030_set_suspend(struct otg_transceiver *x, int suspend)
> {
> struct twl4030_usb *twl = xceiv_to_twl(x);
>
> + /* FIXME This check is added since suspend is getting
> + * called after resume.return in such case
> + */
> + if (twl->otg.last_event != USB_EVENT_NONE)
> + return 0;

I think you need to check why suspend gets called again.

From now on, send mails to the mailing lists, please.

--
balbi