Comment 1 for bug 724096

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Well, I guess we for sure should log such errors to mirror service logs, to see what kind of errors and how often we get. Btw, even from local runs it's clear that android.git.kernel.org is pretty overloaded and from time to time times out or resets connection. Moreover, I saw cases when git did report errors, but repo stills finished with 0 exit code.

Other question is if we should report such failures to XMLRPC caller. If we do, then build will fail (non-deterministic failure). On the other hand, if we don't, we may have a build from a stale codebase which is of course worse. Compromise might to have auto-retrying for repo sync failures, say, 3 times, and then return a failure. This way we'll minimize non-deterministic failures but won't have spurious false positives due to stale codebase.

Still, my first patch is just for capturing and logging results of repo invocations.