lightdm-gtk-greeter-1.7.0: infobar for PAM has red background

[Ulrich Müller]

Forwarding downstream bug <https://bugs.gentoo.org/499044>.

When using lightdm-gtk-greeter with PAM, the infobar used to display PAM messages (e.g., an S/Key challenge) is displayed with a red background, misleadingly indicating an error. See screenshot at <https://bugs.gentoo.org/attachment.cgi?id=368552>.

Presumably, message type GTK_MESSAGE_INFO should be used instead of GTK_MESSAGE_ERROR. (It's an _info_ bar, after all. ;-) Attached patch makes the info bar appear with less obtrusive background.

[Ulrich Müller (ulm)]

Created attachment 368552
Screenshot showing red background in infobar

When using lightdm-gtk-greeter with PAM, the infobar used to display PAM messages (e.g., an S/Key challenge) is displayed with a red background, misleadingly indicating an error.

See attached screenshot. (I haven't touched any of the /etc/lightdm/ configuration files.)

[Ulrich Müller (ulm)]

Created attachment 368554
Patch for src/lightdm-gtk-greeter.c

Presumably, message type GTK_MESSAGE_INFO should be used instead of GTK_MESSAGE_ERROR. (It's an _info_ bar, after all. ;-)

Attached patch makes the info bar appear with less obtrusive background.

[Markos Chandras (hwoarang)]

Thanks for the patch. Would you like to submit it upstream as well?

[Ulrich Müller (ulm)]

(In reply to Markos Chandras from comment #2)
> Thanks for the patch. Would you like to submit it upstream as well?

Sure: https://bugs.launchpad.net/lightdm/+bug/1272652

[Simon Steinbeiß (ochosi)]

We have no control over what messages we get from PAM there, so it could be "anything".

I think the slightly obtrusive color is totally fine, after all, the message calls for attention (and anyway, it shouldn't be visible all the time and always, otherwise that's probably an issue ;)).

[Ulrich Müller (ulm)]

Exactly, you don't know what the message from PAM is. In the pam_skey case it occurs in normal operation. Therefore it is not appropriate to mark it with GTK_MESSAGE_ERROR, which according to the GTK+ documentation is associated with a "Fatal error message".

[ulm (ulm-gentoo-bugs)]

This has been fixed upstream some time ago. Closing.