Comment 3 for bug 1098773

Revision history for this message
Ken VanDine (ken-vandine) wrote :

The dbus functions from friends-service will throw IOError if there is a failure, which contains the error message from the service. There is no output, even on stdout for success. I think catching the error is enough. For the test suite, I agree there is no value in that since we are mocking it anyway, so it will always succeed. However, what we do gain from that is testing for API changes. Which is why ideally I would want the dbusmock to be provided by friends-service instead of contained in libfriends. When python-dbusmock supports loading templates from other packages, we should create a dbusmock template that comes from friends and load that for the interfaces in the libfriends test suite.