Comment 8 for bug 1956885

Hi Kai-Chuan Hsieh

As per my understanding: Tod library talks to libfprintd module and
libfprintd talks to fprintd.
Could you let me know what is changed and what is to be fixed in the tod
driver in compatible with upstream fprintd module?

As per the statement below, I believe ABI is preserved and no changes
required here, if you could let me know any changes to be done from TOD
driver, i will work on it.
------------------

There are currently no plans to backport it to 20.04.

No changes are strictly required on the drivers side, nor they need to be
recompiled (as the TOD v1.90.1 ABI was preserved), however it's strongly
advised to do so, as new internal functions and feature are now available
to use, and the old driver may not take advantage of them.

Thanks,
Prafulla

On Tue, Aug 16, 2022 at 11:15 AM Kai-Chuan Hsieh <email address hidden>
wrote:

> @parafullakota
>
> hello,
>
> I think it is not true, the fprintd-verify is the excutable provided by
> fprintd package from upstream, and Ubuntu hasn't modified anything for
> the package, which means current tod library can't work with upstream
> fprintd correctly.
>
> https://gitlab.freedesktop.org/libfprint/fprintd
>
> Can you fix it first? then we can check if it still has problem on
> Ubuntu 22.04.
>
> Thanks,
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1956885
>
> Title:
> Incorrect verify implementation, unable to verify on one finger
>
> Status in libfprint-2-tod1-broadcom:
> Confirmed
> Status in OEM Priority Project:
> Confirmed
> Status in libfprint package in Ubuntu:
> Confirmed
>
> Bug description:
> The closed-source library blocks on synchronous USB transfers in its
> "verify" method (at least, there might be others with the same issue).
> The "identify" one is correct (asynchronous).
>
> As a result :
> $ fprintd-verify
> Using device /net/reactivated/Fprint/Device/0
> Listing enrolled fingers:
> - #0: right-index-finger
> (finger pressed)
> Verify started!
> Verifying: right-index-finger
> (blocked)
>
> "Verify started!" should happen immediately, but the code libfprint code
> waits for fp_device_verify to return, which only happens when the finger is
> pressed with this driver.
> The verify success message is sent during the call, so it is ignored.
>
> "fprintd-verify -f any" and pam-fprintd use fp_device_identify, so they
> work correctly.
> But with
> https://gitlab.freedesktop.org/libfprint/fprintd/-/commit/fc65055279 (so
> I suppose on jammy), the "verify" method will be used instead if only one
> finger is enrolled.
>
> TL,DR: the fingerprint reader appears to mostly work on focal, but
> starting with jammy it won't unless at least two fingers are enrolled.
>
> Note that this is tested on a Dell Latitude 5521, but the issue should
> be the same with all Broadcom fingerprint readers using this library.
>
> Duplicate bug #1981974
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/libfprint-2-tod1-broadcom/+bug/1956885/+subscriptions
>
>

--
Thanks,
Prafulla Kota
9866544810