Comment 3 for bug 2058622

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Hi Dirk Su,

I cloned the git repo and for instance the debian/changelog is confusing, there are many entries which makes me think that this package is already maintained somewhere else, is this maintained in a PPA and now you are trying to put it in the Ubuntu archive? When the package is landing for the first time in the Ubuntu archive we usually have just a single changelog entry.

The version string you are using does not seem correct. Right now, I see version 1.2ubuntu3. This version string could be used for a native package (something Ubuntu specific), but I see this a project from Lenovo and it is maintained here:

https://github.com/lenovo/lenovo-wwan-unlock

I'd expect a version similar to 2.0.0-0ubuntu1 (version 2.0.0 was releases 2 weeks ago in the repo above). So before the '-' we have the upstream version. And after that, we have the Debian revision, since this package is not in Debian, just in Ubuntu, we use '0ubuntu1'.

I did not read the proprietary license of this software, but in debian/copyright you are using the GPL-3 license for the debian directory. Could you make sure this is OK?

I am also unsure how to generate the tarball for this version, due to that I was not able to build the package and run lintian for instance. However, I think you already have something to work on. I am unsubscribing ~ubuntu-sponsors for now. Once you address the issues presented above subscribe ~ubuntu-sponsors again.