Comment 25 for bug 901498

Revision history for this message
Robert Collins (lifeless) wrote :

I've pushed a branch up that has the right behaviour at least this far:
 - logging output goes to the file
 - log output goes to the file
 - oopses are made when log.err() is called (a log event with isError is emitted)

I didn't reuse setup_tacfile_logging because the contract was all wonky, and keeping it the same would lead to silent WTF's elsewhere.

Other than fixing the obvious fallout the only remaining thing I can think of is to slap a regular logging OOPS adapter on after the basicConfig - this would be useful to turn logging.error() from random places inside LP itself into OOPS reports.

However, I think this is an optional extra and not needed right now, as poppy is meant to be, well, /twisted/.