Comment 14 for bug 881019

Revision history for this message
Monty Taylor (mordred) wrote : Re: [Bug 881019] Re: Lp login is broken after account merge

On 01/20/2012 09:22 AM, William Grant wrote:
> On 20/01/12 00:52, Monty Taylor wrote:
>> It is on our todo list to use the team information from the OpenID
>> response directly in gerrit. Once we do that, I can stop having to do
>> the batch create of user accoutns in gerrit. However, that means a Java
>> patch to Gerrit core, so it's probably not going to get done tomorrow. :)
>>
>> In terms of API additions, team info for a given OpenID identifier would
>> not be useful - what I need is to get via the API is the OpenID
>> identifier for a given user. If I could get that, I could stop
>> screen-scraping.
>
> A user doesn't have a unique OpenID identifier. They can have multiple
> due to account merges, and eventually several from different providers.
> We could possibly allow them to select the primary identity, but really
> you should be looking things at authentication-time, not before.

I can't just look at things at authentication-time, because gerrit has
multiple different access mechanisms. One of those is through the web,
another is ssh. Also, gerrit doesn't support Launchpad's group extension
yet, so the import is the best I've got.

That having been said, it may be the case that a user has more than one
identity in the current system as a happenstance, but is that really the
design? You're telling me that it's on purpose that there is no way to
map the Launchpad User ID "mordred" to the openid identifier that will
be returned if I try to log in via OpenID to that account? I'd love to
hear why that's an intended design and not either a bug or a
happenstance of how account merges got implemented. Up until this point,
everyone else I've spoken to seems to think that the discrepancy is a bug.