Comment 8 for bug 855150

Revision history for this message
Martin Pool (mbp) wrote :

The problem comes from importFromQueue returning a tuple indicating a mail should be sent - though the interface doesn't say so, it actually can return None, None to ask for no mail. POFile already returns None on success, however POTemplate returns an expansion of poimport-template-confirmation.txt. There is also in po_import a _shouldNotify() function, but that only filters out mail to vcs-imports, and it's probably better to suppress based on it being a success, rather than depending on the target person.

The email addresses come from get_recipients and _get_recipients_for_team which does direct store access to get the transitive membership, and I think that it needs to explicitly check the account status is active.

Possible the situation with Henninge was that his canonical address was still preferred; it's not any more.