Launchpad itself

launchpad urls permit spurious whitespace

Bug #819859 reported by Aaron Bentley
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Triaged
Low
Unassigned

Bug Description

URLs containing integer IDs such as /bugs.launchpad.net/mahara/+bug/630891%20/+index are resolved to an object, and arguably they shouldn't be, because rendering such URLs can be problematic. Bug URLs and Merge proposal urls are known to be affected, and many more may be affected. This behaviour is due to Python's loose conversion rules for int().

https://bugs.launchpad.net/mahara/+bug/630891%C2%A0/+index will display the bug but should really display a 404 page.

See original description

Related branches

lp:~abentley/launchpad/url-validation
Gavin Panella (community): Approve
Diff: 158 lines (+70/-5)
2 files modified
lib/canonical/launchpad/webapp/publication.py (+20/-5)
lib/canonical/launchpad/webapp/tests/test_publication.py (+50/-0)
Aaron Bentley (abentley)
summary: - bug urls permit spurious whitespace
+ launchpad urls permit spurious whitespace
description: updated
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r13664 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/13664>.

Changed in launchpad:
assignee: nobody → Aaron Bentley (abentley)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Graham Binns (gmb)
tags: added: qa-ok
removed: qa-needstesting
Robert Collins (lifeless)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Robert Collins (lifeless) wrote :

Rolled back in prod - see bug 825458

Francis J. Lacoste (flacoste)
Changed in launchpad:
status: In Progress → Triaged
assignee: Aaron Bentley (abentley) → nobody
description: updated
Francis J. Lacoste (flacoste)
summary: - launchpad urls permit spurious whitespace
+ Invalid UTF-8 in URL results in an unhandled exception
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Since the fix for bug 819841 landed, spurious whitespace doesn't trigger an OOPS anymore. It displays the page. It should show a 404 instead, but that's not Critical anymore.

summary: - Invalid UTF-8 in URL results in an unhandled exception
+ launchpad urls permit spurious whitespace
description: updated
Changed in launchpad:
importance: Critical → Low
Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Filed bug 852205 for the unrelated 'Please try again' error with invalid UTF-8 in the URL.

William Grant (wgrant)
tags: removed: oops qa-ok
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.