OOPs rendering page with non-ascii URL

Bug #819841 reported by Aaron Bentley
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
Aaron Bentley

Bug Description

Bug tasks permit spurious extra characters in their URLs, e.g. https://bugs.launchpad.net/mahara/+bug/630891%C2%A0/+index

Normally our URLs do no have non-ascii characters, so this reveals some encoding issues handling PATH_INFO: OOPS-2040I14

...
  Module canonical.launchpad.webapp.servers, line 702, in web_service_request_to_browser_request
    return LaunchpadBrowserRequest(body, environ)
  Module canonical.launchpad.webapp.servers, line 614, in __init__
    BasicLaunchpadRequest.__init__(self, body_instream, environ, response)
  Module canonical.launchpad.webapp.servers, line 558, in __init__
    body_instream, environ, response)
  Module zope.publisher.browser, line 243, in __init__
    super(BrowserRequest, self).__init__(body_instream, environ, response)
  Module zope.publisher.http, line 304, in __init__
    environ = sane_environment(environ)
  Module zope.publisher.http, line 73, in sane_environment
    dict['PATH_INFO'] = dict['PATH_INFO'].decode('utf-8')
  Module encodings.utf_8, line 16, in decode
    return codecs.utf_8_decode(input, errors, True)
UnicodeEncodeError: 'ascii' codec can't encode character u'\\xa0' in position 19: ordinal not in range(128)

Tags: oops qa-ok

Related branches

Aaron Bentley (abentley)
Changed in launchpad:
assignee: nobody → Aaron Bentley (abentley)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → Fix Committed
Graham Binns (gmb)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Robert Collins (lifeless) wrote :

We'll probably rollback the deploy with this in it on Monday, due to bug 825458

Revision history for this message
Aaron Bentley (abentley) wrote :

Doh!

Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Robert Collins (lifeless) wrote :

Rolled back in prod - see bug 825458

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :
tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Aaron Bentley (abentley)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.