Bug:+subscribe can't cope with existing BugSubscriptions with a bug_notification_level of NOTHING
Bug #721400 reported by
Graham Binns
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Graham Binns | ||
Bug Description
What happens:
Using the API, set a bug subscription's bug_notificatio
What should happen:
The page (and overlay) should display fine. The validation code should allow for a bug_notifcation
See also bug 721410 and bug 721411.
Related branches
lp:~gmb/launchpad/prevent-bnl-nothing-oopses-bug-721400
- Gavin Panella (community): Approve
-
Diff: 92 lines (+36/-3)3 files modifiedlib/lp/bugs/browser/bugsubscription.py (+5/-3)
lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+26/-0)
lib/lp/bugs/enum.py (+5/-0)
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Graham Binns (gmb) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #2 |
| Changed in launchpad: | |
| milestone: | none → 11.03 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
As an alternate solution that may be simpler, Graham and I talked about a BugMute table that has records of person, bug to only keep track of what is muted. That seems cleaner than the enumeration.