Comment 5 for bug 667183
Revision history for this message
| Julian Edwards (julian-edwards) wrote Re: [Bug 667183] Re: archive.checkUpload() throws exceptionrather than returningFalse | #5 |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
On Wednesday 27 October 2010 15:48:53 you wrote:
> > The only other thought I have is perhaps exporting two APIs,
> > ``checkUpload`` with the current behavior and ``canUpload`` with the
> > requested behavior. That said, someone annoyed by the ``checkUpload``
> > behavior could simply wrap it with a helper function for what I proposed
> > for the ``canUpload`` behavior, and move on.
>
> That's what I was expecting (and what we already doing in
> ubuntu-dev-tools, which has all sorts of launchpadlib wrapping)
>
> Yeah, the only issues with it are that it's not Pythonic, and that the
> documentation says nothing about throwing exceptions instead of
> returning something.
Right, the documentation is bad, I will update that.
The checkUpload() itself is wrapping something that doesn't raise exceptions.
We can expose that to return True or False if it helps.